Product Preview Card with HTML & CSS

Community feedback

• Account deletedPosted almost 3 years ago

  Hey @DrStranger1, adding to what was said above/below:

  • The images and text content need to be wrapped together in container.

  • The Alt Tag Description for the image needs to be improved upon. You want to describe what the image is; they need to be readable. Assume you’re describing the image to someone.

  • There is only one heading in this challenge and that is the name of the perfume, “Gabrielle Essence Eau De Parfum”.

  • To the have the both prices be horizontally centered, use display: flex along with align-items: center on the container.

  • Button hover color is incorrect. It should be a dark green instead it is a light blue.

  • The old price 🏷 is not being announced properly to screen readers. You want to wrap it in a Del Element and include a sr-only text explaining that this is the old price.

  • Your component is not responsive. You want to use responsive properties and media queries to make it so.

  Happy Coding! 👻🎃

  11

  Marked as helpful
• 

  Adeola Ganiu•1,320

  @Deolabest

  Posted almost 3 years ago

  Hey @DrStranger1, Congratulations on completing this challenge!

  Here is my feedback:

  • You don't to add width: 1440px; to the body.

  • To center a container at the center of the page, do this:

  body {
      flex-direction: column;
      align-items: center;
      justify-content: center;
      display: flex;
  }
  

  • I also noticed you used this <div class="main">. Main is a semantic tag on its own, so you don't need to use it as div class.

  Keep doing a good job!

  11
• 

  Lucas 👾•104,160

  @correlucas

  Posted almost 3 years ago

  👾Hello @DrStranger1, Congratulations on completing this challenge!

  Your solution its almost done and I’ve some tips to help you to improve it:

  Use the THE PICTURE TAG that is a shortcut to deal with the multiple images in this challenge. So you can use the <picture> tag instead of importing this as an <img> or using a div with background-image. Use it to place the images and make the change between mobile and desktop, instead of using a div or img and set the change in the css with display: none with the tag picture is more practical and easy. Note that for SEO / search engine reasons isn’t a better practice import this product image with CSS since this will make it harder to the image. Manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device desktop + mobile.

  Check the link for the official documentation for <picture> in W3 SCHOOLS: https://www.w3schools.com/tags/tag_picture.asp

  See the example below:

  <picture>
    <source media="(max-width:650px)" srcset="./images/image-product-mobile.jpg">
    <img src="./images/image-product-desktop.jpg" alt="Gabrielle Parfum" style="width:auto;">
  </picture>
  

  👨‍💻Here's my solution for this challenge if you wants to see how I build it: https://www.frontendmentor.io/solutions/product-preview-card-vanilla-css-and-custom-hover-state-on-hero-85A1JsueD1

  ✌️ I hope this helps you and happy coding!

  01