Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 year ago

Product Preview card with HTML, CSS only

Duy Anh Le•120
@leanhduy
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

In the next update, I would try to write styles using a pre-processor (Sass)

What challenges did you encounter, and how did you overcome them?

Challenges

  1. The difference of element position between mobile (image on top of content) vs desktop (side by side) Overcame by using a wrapper div and applying display:flex in the desktop mode
  2. Conditional loading different size of image for different screen size by using html only. Overcame by self-research and found out the `` tag.
What specific areas of your project would you like help with?

Nothing for now.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ralph Virtucio•710
    @ralphvirtucio
    Posted about 1 year ago

    Hi Duy Anh Le, Good job on doing this challenge 🙌🙌🙌

    These are my suggestions to your project:

    • I'd like to suggest, creating a README.md for your project. Even though this is a small project writing README on every project will set your awareness as a developer if the project has a README file. This is important because README communicate important information about a project. Check out this article to learn more about README Check out this article to learn the benefits of writing a good README

    • Try also refactoring your HTML code to semantic HTML. Writing Semantic HTML will improve your websites Accessibility, SEO, Readability Check out this article to learn Semantic HTML and it's importance for accessibility

    • It is also not a good practice to have two <h1></h1> tag element in your code. I'd suggest to update <h1></h1> tag element of the discount price to <p></p> tag element, you can create a label for both prices and then set the class of the labels to visually-hidden this will hide the labels on the UI but when a screen reader reads your this website it will mention the price labels, Here is a sample code

    <div class="product-price">
          <div class="product-price__discount-container">
               <span class="visually-hidden">Discounted Price</span>
                <p class="product-price__discounted">
                    $149.99
                 </p>
             </div>
            <div class="product-price__original-container">
               <span class="visually-hidden">Original Price</span>
                <p class="product-price__original
                 price">
                    $169.99
                </p>
           </div>
    </div>
    

    If you want to learn more about visually hidden, try checking out this article

    • Try also setting a reset for your CSS this will remove inconsistent margins, paddings, line-heights and other attributes that can cause your web pages to look differently across various browsers Check out this article if you want to learn more about CSS reset

    • If you want to center your card, You can set a min-height property to your body selector with a 100vh value and set a display property with a value of flex then center everything out. I'd suggest resetting your CSS first before doing this.

    I like the card-links to your different challenges ! !

    CODE UP 🧑‍💻🧑‍💻!*

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub