Product-preview page using HTML and CSS

Please log in to post a comment
Log in with GitHubCommunity feedback
- @EdwinNdambiri
Nice
- P@dev-ethanjohn
Hey Leo, I hope you are well.
Your HTML structure looks good and your code is good enough for semantics. Good way you use main for this. There are things I may recommended you to check out.
- You can add article or header on your HTML for better semantics.
- Using px on media query is valid, but I recommend you use
em
for better scaling and for accessibility. - I notice on mobile, the image is not displaying, try to fix your src.
- It would be better if you try to emulate as much as possible the design specifics even if these are minor styles like line-spacing, your use of font-family on some components, and among other things.
Wish you success and more power!
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord