Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product review card

Calebā€¢ 180

@xdcron

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Very happy with how this came out .would love to hear some feedback.

Community feedback

@0xabdulkhalid

Posted

Hello there šŸ‘‹. Congratulations on successfully completing the challenge! šŸŽ‰

  • I have other recommendations regarding your code that I believe will be of great interest to you.

DECORATIVE SVG'S ā™Øļø:

  • The alt attribute is used to provide alternative text for images in HTML documents. The alt attribute is used by screen readers to describe the image to visually impaired users, which is essential for web accessibility.
  • Now, when it comes to decorative SVGs, they are used purely for aesthetic purposes and do not convey any important information or functionality to the user.
  • Since these images do not convey any important information or functionality, there is no need for an alt attribute.
  • So feel free to set the alt attribute as "" for decorative svg's, because alt="" will be skipped by screen readers they will consider the image as decoration

Example:

<img src="images/decorative.svg" alt="">

<img src="img/icon-cart.svg" alt="Cart-icon" class="cart">
šŸ‘‡
<img src="img/icon-cart.svg" alt="Cart-icon" class="">

.

I hope you find this helpful šŸ˜„ Above all, the solution you submitted is great !

Happy coding!

Marked as helpful

1
Adeola Ganiuā€¢ 1,320

@Deolabest

Posted

Hey @xdcron, Congratulations on completing this challenge!

Here is my feedback:

  • You don't need a div for main-container when you already have the main element.

Keep doing a good job!

Marked as helpful

1
Kuraanalā€¢ 210

@Kuraanal

Posted

Hey.

Instead of having a container "First-box" with 2 images inside and switching display in the css, you can use a 'Picture' tag with a sourceset and let the browser decide which one to load.

<picture class="first-box">
<source srcset="img/image-product-desktop.jpg"
media="(min-width: 600px)"/>
<img src="img/image-product-mobile.jpg" alt="Eau De Parfum"/>
</picture>

You can find more about the picture tag here: Picture Tag info page

Marked as helpful

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord