Skip to content
Submitted over 2 years ago

Product review card: flexbox, grid, figure, picture

devusexu•130
@devusexu
A solution to the Product preview card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

  1. How to name color variables? primary, neutral, cornflower, blue, ...?
  2. When to use %? I use rem/em in most cases and px for margin/padding
  3. I put everything in figcaption, is that right? Because I think all of the information is about the picture, so they are all caption.
  4. Is there too much explicit width? including max-width and max-height
  5. Better ways to write HTML & CSS: semantics, too many div?, class usage, CSS code refactoring

Any comments are welcomed! Thanks for reading this submission

Code
Loading...

Please log in to post a comment

Log in

Community feedback

No feedback yet. Be the first to give feedback on devusexu's solution.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord