Submitted over 2 years ago

Product Review Card (HTML - CSS)

accessibility

Adrian Silva•80

@adjsvar

A solution to the Product preview card component challenge

Preview Code

Solution retrospective

Something i did fast, nothing fancy, as always any advice will be apreciated. a big hug.

PD- idk why but the "screenshot" img its weird.

Code

Please log in to post a comment

Community feedback

Account deletedPosted over 2 years ago
Hey @adjsvar, great job on this project!

Some suggestions to improve you code:
- When using images that are different size for different breakpoints, its’ far more effective to use the <picture> element. By using this element not are able to use different size images, you can also save on bandwidth, meaning your content loads faster.
Syntax:
```
  <picture>
    <source media="(min-width: )" srcset="">
    <img src="" alt="">
  </picture>
```
Source:

https://www.w3schools.com/html/html_images_picture.asp

https://web.dev/learn/design/picture-element/
- To make you content accessible to your users, it is a best to use rem/em instead of px for your CSS property values. For media queries, I definitely suggest using em for them. By using px your assuming that every users browser (mobile, tablet, laptop/desktop) is using a font size of 16px (this is the default size on browser). Em's will help with users whose default isn't 16px, which can sometimes cause the your content to overflow and negatively affect your layout.
Sources:

https://betterprogramming.pub/px-em-or-rem-examining-media-query-units-in-2021-e00cf37b91a9

https://uxdesign.cc/why-designers-should-move-from-px-to-rem-and-how-to-do-that-in-figma-c0ea23e07a15
- While having interactive content (cards, links, icons, buttons, etc…) can definitely make content less static, if not done properly, it can actually have negative effect on your users experience. By simply just applying a “hover” effect to your content, you’re assuming that every device is compatible with “hover” effects. Unfortunately, most devices are not. To provide your users a better experience, you can use the @media (hover: hover) . Now users that that are devices that are not “hover” compatible will be able to enjoy your content.
Sources:

https://css-tricks.com/solving-sticky-hover-states-with-media-hover-hover/

https://youtu.be/uuluAyw9AI0

Happy Coding!
Marked as helpful
Lucas 👾•104,160
@correlucas
Posted over 2 years ago
👾Hello @adjsvar, Congratulations on completing this challenge!

Your solution its almost done and I’ve some tips to help you to improve it:

Add the website favicon inserting the svg image inside the <head>. <link rel="icon" type="image/x-icon" href="./images/favicon-32x32.png">

IMPROVE YOUR WORKFLOW using VSCODE you can code your whole page using px and then in the end use a plugin called px to rem here's the link → https://marketplace.visualstudio.com/items?itemName=sainoba.px-to-rem to do the automatic conversion or use this website https://pixelsconverter.com/px-to-rem

For future projects, think about using relative units as rem or em instead of px to improve your performance by resizing fonts between different screens and devices.

Using <picture> you’ve more control over the elements and its better than using the product image as <img> or background-image. Look that for SEO and search engine reasons it isn't a better practice to import this product image with CSS since this will make it harder to the image. You can manage both images inside the <picture> tag and use the html to code to set when the images should change setting the device max-width depending of the device (phone / computer) Here’s a guide about how to use picture: https://www.w3schools.com/tags/tag_picture.asp

✌️ I hope this helps you and happy coding!
Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord