Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product Review Card Using Flexbox

@thejackshelton

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


What could I have done to make this shorter?

I think 180 lines of CSS for this is probably a lot longer than it should be. Would love to see other solutions

Community feedback

Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

Hey Jack, It looks good!... You have accessibility issues that need to fix.

  • Document should have one main landmark, Contain the component with <main>.
<main>
   <div class="container">
      //...
   </div>
</main>
  • Page should contain a level-one heading, Change h2 to h1 You should always have one h1 per page of the document... in this challenge, you will use h1 just to avoid the accessibility issue that appears in the challenge report... but don't use h1 on small components <h1> should represent the main heading for the whole page, and for the best practice use only one <h1> per page.

  • All page content should be contained by landmarks, Contain the attribution with <footer>.

<footer>
   <div class="attribution">
      //...
   </div>
</footer>
  • I suggest you align items by using margin and padding instead of position --->Alignment, margin, padding

  • Use REM for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?

Hope this help!... Keep coding👍

Marked as helpful

0

@thejackshelton

Posted

@Bayoumi-dev Very detailed explanation! Thanks.

I've updated the code on the accessibility issues.

Going forward I will use rem for font-size!

0
Ahmed Bayoumi 6,800

@Bayoumi-dev

Posted

@thejackshelton You're welcome 😊

0

@thejackshelton

Posted

@Bayoumi-dev done :)

0

@joaojgabriel

Posted

I think it's pretty short, and you shouldn't worry too much about it. One thing that would help is using shorthands, like for margin and border-radius. Other than that, you can keep in mind it was possible to write a more declarative code using Flexbox in the text content. But take those notes as avenues to try out in further challenges/projects, and don't get too hung up on perfectionism. This one's already great. :)

0

@thejackshelton

Posted

@joaojgabriel Appreciate the advice! I'll take a look into declarative programming.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord