@Bayoumi-dev
Posted
Hey Jack,
It looks good!... You have accessibility issues
that need to fix.
Document should have one main landmark
, Contain the component with<main>
.
<main>
<div class="container">
//...
</div>
</main>
-
Page should contain a level-one heading
, Changeh2
toh1
You should always have oneh1
per page of the document... in this challenge, you will useh1
just to avoid theaccessibility issue
that appears in the challenge report... but don't useh1
on small components<h1>
should represent the main heading for the whole page, and for the best practice use only one<h1>
per page. -
All page content should be contained by landmarks
, Contain the attribution with<footer>
.
<footer>
<div class="attribution">
//...
</div>
</footer>
-
I suggest you align items by using
margin
andpadding
instead ofposition
--->Alignment, margin, padding -
Use
REM
for font size, It is a must for accessibility because px in some browsers doesn't resize when the browser settings are changed... See this article ---> CSS REM – What is REM in CSS?
Hope this help!... Keep coding👍
Marked as helpful
@thejackshelton
Posted
@Bayoumi-dev Very detailed explanation! Thanks.
I've updated the code on the accessibility issues.
Going forward I will use rem for font-size!
@Bayoumi-dev
Posted
@thejackshelton You're welcome 😊
@thejackshelton
Posted
@Bayoumi-dev done :)