Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Product review with SASS

#sass/scss

@anacatarinafg

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Alamin 1,960

@CodePapa360

Posted

Hi Ana Gonçalves 👋 Great job on completing this challenge! 🥳 Your layout looks great.

Here are a few suggestions to further improve your code:

  • Consider using more specific CSS selectors to avoid potential conflicts with other elements on the page. For example, instead of .card__leftSide .card__image, you could use .card__image--left and .card__image--right, or simply .card__image--left and .card__image--right.

  • Consider using CSS variables to define and manage colors, fonts, and other common styles. This will help ensure consistency across your site and make it easier to make changes later on

  • Make sure to follow consistent naming conventions for your classes and IDs. For example, in your main element you have a .card class, but outside of main you also have a .card class. This could lead to confusion or unexpected behavior in your CSS. Consider using more descriptive names like .product-card or .pricing-card instead.

Hope I'm Helpful! 👍

Keep up the good work and happy coding!! 😊❤️

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord