Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

product-preview-card-component

#react#sass/scss#semantic-ui#tailwind-css

@reesjr

Desktop design screenshot for the Product preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


responsive design was a challenge to me when working on this project I'm still unsure if i did well enough on the media query

Community feedback

Travolgi 🍕 31,500

@denielden

Posted

Hi Seerees, congratulations on completing the challenge, great job! 😁

Some little tips for optimizing your code:

  • the image is broken because the src is wrong, fix like this: images/image-product-desktop.jpg or ./images/image-product-desktop.jpg burt not with single slash /
  • use main tag to wrap the all content of page and improve the Accessibility
  • img element must have an alt attribute, it's very important!
  • You can use picture tag to see different image in different resolution read here
  • use min-height: 100vh to body instead of height, otherwise the content is cut off when the browser height is less than the content
  • instead of using px or % use relative units of measurement like rem -> read here

Hope this help! Happy coding 😉

Marked as helpful

0

@reesjr

Posted

@denielden Thanks so much . I’ll make the needed adjustment ASAP!!

1
Travolgi 🍕 31,500

@denielden

Posted

@reesjr You are welcome and keep it up :)

0
imad 3,310

@imadbg01

Posted

Greeting seerees doboyi!! Congratulations for completing your first challenge, 👏👏👏.

you did great job using flex, but the path to images need an update, as for now the images not showing up, fix -

<img src="./images/image-product-desktop.jpg" alt="" class="img">
    <img src="./images/image-product-mobile.jpg" alt="" class="img-2">

you can read about Dealing_with_files.

Overall, have a great day/night, and keep coding 👍.

Marked as helpful

0

@reesjr

Posted

@imadbg01 Thank you so much for pointing this out. Got a little carried away by the excitement of completing my first challenge . I’ll fix up !!

1
imad 3,310

@imadbg01

Posted

@reesjr You are welcome bro

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord