product-preview-card-component

Community feedback

• 

  Abdul Khaliq 🚀•72,380

  @0xabdulkhaliq

  Posted about 2 years ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  BODY MEASUREMENTS 📐:

  • The width: 100vw property for body element is not necessary. because it's a block level element which will take the full width of the page by default.

  ---

  • Use min-height: 100vh for body instead of height: 100vh. Setting the height: 100vh may result in the component being cut off on smaller screens.

  ---

  • For example; if we set height: 100vh then the body will have 100vh height no matter what. Even if the content spans more than 100vh of viewport.

  ---

  • But if we set min-height: 100vh then the body will start at 100vh, if the content pushes the body beyond 100vh it will continue growing. However if you have content that takes less than 100vh it will still take 100vh in space.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  00

  Marked as helpful
• Account deletedPosted about 2 years ago

  Impressive work ✨, Congratulations

  here is some suggestions for your code:

  • you don't need a <div> tag with class="card", yoi can just remove it and assign this class to the <main> tag
  • it seems like you're using the same image on the desktop and mobile screens, try to change your code so it change the image depending on the screen size
  • you don't need media query like this

  @media screen and (max-width: 375px), 
   (max-width: 425px)
  

  • you can just use this:

  @media screen and (max-width: 425px)
  

  • you can add :hover effect to the button to make it more beautiful

  Good luck in the next 🔥, keep going on

  00

  Marked as helpful