Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 2 years ago

product-preview-card-component-main

Bader Idris•2,880
@Bader-Idris
A solution to the Product preview card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Melvin Aguilar 🧑🏻‍💻•61,020
    @MelvinAguilar
    Posted about 2 years ago

    Hello there 👋. Good job on completing the challenge !

    I have only a suggestion about your code that might interest you.

    • Using position: relative is a valid way to center an element in the middle of the screen, but the use of flexbox is generally considered a more modern and flexible approach because it requires less code and is more intuitive.

      The problem of using position: relative in this challenge:

      If you have only one component on the page and it is relatively large in height, using position: absolute with top: 50%; and left: 50%; may not work as intended in landscape mode on mobile devices ⚠️. This is because the height of the screen becomes relatively smaller compared to its width in landscape mode, which may cause the component to overflow the screen and make it difficult for users to interact with.

      • This is your solution in a real mobile device (landscape mode): screenshot-imgur (landscape mode)📸

        Explanation: The image is completely cut off, valuable information for the user is lost.

      • I can replicate the same error in your QR code challenge, and if it's cropped too much, it may make it impossible to scan the QR code. :(

        screenshot-imgur (landscape mode)📸

    I hope you find it useful! 😄

    Happy coding!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub