Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile card

Mohamed Ibrahemβ€’ 20

@moibrahem98

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


any feedback about my best practice

Community feedback

Renszo Camachoβ€’ 1,615

@RenszCamacho

Posted

Hiya πŸ‘‹πŸ» moibrahem98.

Good job mate πŸ‘πŸ‘πŸ‘. You have done a fantastic job on this challenge πŸ‘Œ, place properly the background image is quite tricky.

Just a few suggestions IMHO.

  • Add an alternative text to your images. <img class="person" src="images/image-victor.jpg" alt="victor" />

  • I would add a CSS reset, to avoid some annoying margins.

* { margin: 0; padding: 0; box-sizing: border-box; }

  • To place the background-images:

body { background-image: url(../images/bg-pattern-top.svg), url(../images/bg-pattern-bottom.svg); background-position: right 50vw bottom 50vh, left 50vw top 50vh; background-repeat: no-repeat; background-color: hsl(185, 75%, 39%); display: flex; justify-content: center; align-items: center; width: 100%; height: 100vh; }

  • To center the card.

.card__body { width: inherit; height: inherit; display: flex; justify-content: center; align-items: center; }

Happy codingπŸ§‘β€πŸ’»

1

Mohamed Ibrahemβ€’ 20

@moibrahem98

Posted

@RenszCamacho Words cannot express how grateful I am for your kindness and generosity <3 <3 <3

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord