Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

Profile Card Component - HTML CSS

Slim•145
@SlimBloodworth
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


FINALLY! Sorry, I was having some trouble with GitHub Pages... Any feedback is welcome and appreciated! There are some things I'd really like to target though. Feedback on the code itself - thoughts on drying it out and best practices , as well as, thougnhts on how it might be simplified.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart
    Posted over 3 years ago

    Hey, great work on this one. Layout in general looks great but it needs to be responsive/adaptable.

    Muh Suryadi Triputra Rahman gave great tip in git, just going to add some suggestions on the site itself:

    • Always have a main element to wrap the main content of your page. On this one, the .card-container should be using the main instead of section.
    • On the .card-container instead of width: 350px; use max-width: 350px because using the former makes an explicit width which makes the element not scale and just have fixed width. Also on the image background of the card, use and width: 100% so that it will scale as well.
    • Decorative image must be hidden at all times by using alt="" and extra aria-hidden="true" attribute on the img tag. Hide the img inside of the .card-top.
    • Also when using alt attribute, avoid using words that relates to "graphic" such as "background" and others. An img is already an image/graphic so no need to describe it as one.
    • Person's img should be visible because it is a meaningful image in the component so use the person's name as the alt like alt="Victor Crest".
    • A page must have a single h1 on a page. Since there are no text-content that are visible that could be h1, you will make the h1 screen-reader only text. Meaning this will be hidden for sighted users and only be visible for screen-reader users, search about sr-only stylings and see how it is used. The h1 text should describe what is the main content is all about, this h1 would be placed as the first text-content inside the main element.Have a look at Grace's solution on this inspect the layout and see how she used the h1 as well the stylings applied to it, copy that since you will need that a lot. But if you aren't comfortable right now, maybe use h1 on the person's name.
    • The london should not be a heading tag, use only p tag on it. Use only heading tag if the text gives an overview to what a section contains all about.
    • On the .activity-tracker you could use ul on it since those are "list" of information about the user. I wouldn't explain the next section in since on the link that I gave you, you will a proper markup on that.

    Aside from those, great work again on this one.

    Marked as helpful
  • Muh Suryadi Triputra Rahman•380
    @msuryaditriputraR
    Posted over 3 years ago

    I also had the same problem.. you can try this

    git commit --allow-empty -m "Trigger rebuild"

    git push

    and refresh your page

    it worked for me.. happy coding

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub