Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile card component

ivan parra 610

@ivanparraoda

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


If you have any tips on how to improve my coding. Let me know feedback is always welcome

Community feedback

Vanza Setia 27,835

@vanzasetia

Posted

Hello there, Ivan! 👋

Nice work on this challenge! 🙌 Your solution is responsive without media queries and looks great! It's amazing that you can handle those background patterns. 👏 When I was doing this challenge I couldn't figure it out by myself. 😅

Anyway, some suggestions from me.

  • The photo needs an alternative text so that all users know that there's a photo of Victor Crest. It might also useful for SEO. So, the alternative text for the photo should be Victor Crest. For your information, alternative text for images should not contain any words that related to image (e.g. picture, photo, logo, icon, graphic, avatar, etc). It's already an image element so the screen reader will pronounce it as an image.
  • I would highly recommend adding justify-content: center and then removing the margin: 0 auto from the .container element. Even better, you can remove the .container element entirely and put the text-align property into the body element. This way, you can clean up the HTML.

Overall. great work. You manage to handle those background images and finish this challenge without any media queries.. Also, it would be great if you can remove the .container element because I think you might not need it actually.

I hope this information is useful! Keep up the excellent work! 👍

Marked as helpful

0
Kelvin 915

@Kl3va

Posted

Hi Ivan. Your solution looks good. Moving on, try to adopt html semantics. For example; replacing your div container with a main tag and using h1 as a first level heading and not the h2

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord