Skip to content
Submitted over 3 years ago

Profile card component

Macdeesh•610
@macdeesh
A solution to the Profile card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

Hello everyone !! If you have any comments or suggestions to improve my code, feel free to comment. Your feedback is appreciated. Thank you.

Code

Please log in to post a comment

Log in

Community feedback

  • Obaida Shurbaji•250
    @obaidash99

    Nice work you did here! Congrats.

    There is only the issue of accessibility, the code should contain at least one h1 heading for more semantic HTML. And don't skip the numbering of the heading, that means when you write an h1, you should write an h2 next time you need a smaller heading or something, then you can style them as you want them to be.

    Hope this helps!

    Marked as helpful
  • Macdeesh•610
    @macdeesh

    Hey Obaida, Thank you for your advice, I already saw it in the report as an accessibility issue and to be honest it was intentional to use h2 instead of h1, because normally this card component should exist as a div inside a body of a full web project, and it has no meaning to use a level-one heading in a profile card. Anyway, thank you again, and I hope we keep in touch with constructive feedbacks for our next projects. Happy coding.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord