Profile Card component

Solution retrospective
Any feedback will be highly appreciated. thank you!
Please log in to post a comment
Log in with GitHubCommunity feedback
- @NomiDomi
Hey @4gotpwd,
Really great job with picking your class names. Your html is general and easy to understand.
For the css part I would encourage you to add not just the colors to your :root selector, but the font family, sizes, paddings, margins etc. Here is a great tutorial that explains why and how.
I see you used different types of units which is great! If you want a better and smoother responsiveness, try focusing on using other units than pixels for margins, paddings and font sizes. You can see here what the best practices are.
Overall great job! :) Hope this helps! Keep coding!!
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord