Looking to hire developers?
Feedbacks are welcome!
@artimys
Posted
Hi Conner, you pretty much nailed the matching to the design. Especially with those background images.
The only minor thing I would suggest is for the bottom background image to stick to the right edge of the viewport.
Awesome job!! š
@zuolizhu
Posted
@artimys Thanks for your suggestion š!
@ApplePieGiraffe
Posted
Hey, Connor Z! š
I'm so happy to see you submit another challenge! Your solutions always inspire me! š
This one's another pixel-perfect solution that looks great! š
Keep coding (and happy coding, too)! š
@ApplePieGiraffe
Posted
@ApplePieGiraffe
BTW, I just recently submitted a solution to the Room Homepage challenge in which (inspired by your solution to the same challenge) I did the exact same thing you did and added the same intro animation using GSAP and stolen (I, I mean, learned) from Dev Ed! š
@zuolizhu
Posted
@ApplePieGiraffe The transition of the carousels are amazing š„³! I will steal your idea for my next carousels project š hahaha!
@ApplePieGiraffe
Posted
@zuolizhu
š
@brasspetals
Posted
Hi, Connor! Overall, the solution looks great!
I'll preface this by saying I know nothing about React, but I noticed at 479px~480px the card shifts vertically on both Chrome and Firefox. I'm not sure what's causing it, but thought you might like to know. Otherwise, no other issues that I can see!
@zuolizhu
Posted
Hi @brasspetals ,
That's a nice catch up on the little detail š! But don't worry, its just because I set a break point where the padding top changed from 147px to 173px š¤£ (for presenting purpose, make it looks like same as the design file).
React is over complicated for this kind of project, but it is worth to try out on some large size project, I will make one in my coming project solution š
Happy coding š!
@brasspetals
Posted
@zuolizhu Welp, I'm half an idiot - can't believe I missed the blatantly obvious. š¤¦āāļø š This is why I should really stick to my typical rule of not commenting on challenges I haven't completed myself, and also not commenting so late at night! Apologies!
@zuolizhu
Posted
@brasspetals LOL it's okay š! I appreciate you looked into my work and make any of the suggestions, that makes me motivated and keep improving š!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
