Account Deleted
Hey Mate, good job on this one!
First, I am curious as to why you have a style tag at the bottom of the file? Normally you can defer noncritical CSS, but seeing as the CSS in this component is essentially everything featured on the page, it is incorrect in this instance to do that. This is also not the correct way to defer CSS.
You should also use alt tags on images where possible. This assists people who use screen readers to access your content.
Regarding the CSS, you have quite a few redundant and unnecessary rules. For instance, the width on your ".profile-card" component does nothing. The use of CSS Grid is also completely unnecessary here. Grid is useful for 2D layouts. Seeing as this is a 1D layout, you should use flexbox for this. You also do not need to specify an explicit height on this element, especially using a confusing measurement like "23.2em". What you should do is simply use margins and padding to make the element have the height you need. This is a lot easier and less error prone to do. You also do not need to set overflow: hidden on this element.
When sizing elements you should simply allow the contents to determine the height, that way you do not need to fight CSS to make your layout work. Padding and margins are your friend here, use them correctly.
Apart from that great work!
Marked as helpful
@0xabdulkhalid
Posted
@ashmaddenweb
Thanks for noticing those errors
In future i want to refractor the css rules