Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Profile Card Component Challenge

Mark Sainsbury•45
@Sa1ners
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is my first challenge so all feedback welcome. the one think i struggled with was making the background smaller as my live version looks to large.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Hachi•155
    @hachi-ops
    Posted over 4 years ago

    Just checked: quotes between brackets aren't necessary: url('...') or url(...) doesn't matter. I didn't have them in my solution and it loaded pictures anyway but it is considered a good practice to include them.

  • Hachi•155
    @hachi-ops
    Posted over 4 years ago

    Yes you can have two images separated by commas:

    background-image: url('...') , url('..');

  • Hachi•155
    @hachi-ops
    Posted over 4 years ago

    Hello Mark, You are missing double quotes in your index.html in line 36 (but I don't think this is the reason why it displays incorrectly :)

    Actually the design is there if you scroll down. It shows the card exactly in the middle of the page:) Vercel should update git hub changes automatically but maybe if you try to login to Vercel again and see what happens.

  • Grace•32,130
    @grace-snow
    Posted over 4 years ago

    Yep, we can't see anything. Did you push your latest code up to the repo? Make. Sure everything is staged, committed and pushed, then update your solution and generate a new screenshot & report.

    Good luck

  • Ever Daniel•35
    @edgg72
    Posted over 4 years ago

    Hello Mark, it seems that you didn't upload everything correctly, check that again.

  • Hachi•155
    @hachi-ops
    Posted over 4 years ago

    This comment was deleted over 4 years ago

  • Mark Sainsbury•45
    @Sa1ners
    Posted over 4 years ago

    ok thats appreciated. can you have two images as background-image lines within the body CSS entry? I will also try removing the background-size:cover entry.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Frontend Mentor for Teams

Frontend Mentor for Teams helps companies and schools onboard and train developers through project-based learning. Our industry-standard projects give developers hands-on experience tackling real coding problems, helping them master their craft.

If you work in a company or are a student in a coding school, feel free to share Frontend Mentor for Teams with your manager or instructor, as they may use it to help with your coding education.

Learn more

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub