Looking to hire developers?
This is my first challenge so all feedback welcome. the one think i struggled with was making the background smaller as my live version looks to large.
@hachi-ops
Posted
Just checked: quotes between brackets aren't necessary: url('...') or url(...) doesn't matter. I didn't have them in my solution and it loaded pictures anyway but it is considered a good practice to include them.
@Sa1ners
Posted
@hachi-ops Thats great, many thanks indeed.
@hachi-ops
Posted
Yes you can have two images separated by commas:
background-image: url('...') , url('..');
@hachi-ops
Posted
Hello Mark, You are missing double quotes in your index.html in line 36 (but I don't think this is the reason why it displays incorrectly :)
Actually the design is there if you scroll down. It shows the card exactly in the middle of the page:) Vercel should update git hub changes automatically but maybe if you try to login to Vercel again and see what happens.
@Sa1ners
Posted
@hachi-ops thanks, good spot on the quotes!
i have made some changes so hopefully it will look better this time, although the Frontend mentor site looks like it is down at the moment!
Yep, we can't see anything. Did you push your latest code up to the repo? Make. Sure everything is staged, committed and pushed, then update your solution and generate a new screenshot & report.
Good luck
Actually, code is there! Did you preview this? I think you need quite a few changes to this...
From a quick glance I would recommend:
I think the reason we can't see anything in your site is because of the position absolute at the moment on the card. That takes it out of the normal document flow. So when you set the height of the container to auto, the container thinks its got no content, so it doesn't need any height.
The changes I suggest will help. I think.
Good luck with it 👍
@Sa1ners
Posted
Grace, Many thanks indeed for taking the time to review and respond to my project. It's incredibly useful for me as a new developer.
@Sa1ners you're welcome. Remember to upvote comments you find helpful on here so people can develop mentoring skills ☺
@edgg72
Posted
Hello Mark, it seems that you didn't upload everything correctly, check that again.
@hachi-ops
Posted
This comment was deleted
@Sa1ners
Posted
@hachi-ops i think you created a fork, but like you i am new the github! thanks for the additional feedback though.
@Sa1ners
Posted
ok thats appreciated. can you have two images as background-image lines within the body CSS entry? I will also try removing the background-size:cover entry.
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
