Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile card Component HTML and CSS

Patryk 40

@patrykj369

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hi, Please, doing a code review my component.

Community feedback

Tereza 605

@sirriah

Posted

Hello, good work. I saw your code and I found a few things that could be improved.

  • please, don't use names like "item" - try to find names that better describe the component. You can use BEM naming.
  • write mobile css first
  • for the two big circles on background you can use pseudo elements ::before and ::after.
  • I recommend you Kevins tutorial about units. Happy coding :)
2

@keith-price

Posted

Agreed. I used psuedo ::before and ::after for the circular gradients.

1
Patryk 40

@patrykj369

Posted

@sirriah thanks for your opinion ;)

0

@pikapikamart

Posted

Hey great work you got there. The background positioning is maybe a little but hey, you still the pretty much the card main component. One thing to add, instead of

background: url(./images/bg-pattern-bottom.svg),url(./images/bg-pattern-top.svg);
    background-size: 500px;
    background-repeat: no-repeat, no-repeat;
    background-position-x: 200px, -300px;
    background-position-y: 500px, -100px;
    background-color: hsl(185, 75%, 39%);

declaring multiple background property like that. You could just implement them in the background property in one liner like this one background: url(./images/bg-pattern-bottom.svg) no-repeat- 200px 500px , url(./images/bg-pattern-top.svg) no-repeat -300px -100px you know just to avoid declaring long lines of properties. Honestly, I may talk about this but I don't know how to add background-color and background size in the background property. Other than that, good work^

1

Patryk 40

@patrykj369

Posted

@pikamart thanks for your opinion ;)

0

@pikapikamart

Posted

@patrykj369 Your welcome on that^^

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord