Mark Teekman• 365
@markteekman
Posted
Hey Haico, nice first solution, looks great 👍🏼
Some suggestions on how to improve your code:
- You could try using a
<footer>landmark instead of a div with a class of footer for better markup - Also wrap your card in a
<main>tag for a better and more accessible markup (these first two points should tackle most of your accessibility warnings) - You could set the background on the
<body>instead of using a separate div to clean up the code a bit
Keep up the good work!
Marked as helpful
1
Haico Paulussen• 170
@Haico-Paulussen
Posted
@markteekman Thanks for the feedback Mark!
I improved my code with your suggestions. It's a lot better now!
1
Mark Teekman• 365
@markteekman
Posted
@Haico-Paulussen looks really nice! 😃
0
