@vanzasetia
Posted
πHi Pop Andrei!
Thanks for leaving your kind words on my solution π.
Some feedback on this solution:
- I would not recommend to limit the
height
of thecard
. Let the content inside it control the height of it. - I notice that you often use
%
percentage units. I would recommend to userem
orem
instead to make the size consistent among devices. - I would highly recommend to use
details
andsummary
tag instead of input tags. - You don't need to specify the
height: 100%;
of thebody
andhtml
elements, it's unnecessary. - For the card images, what I did, I used
img
element for overflowing images and use CSSbackground-image
for the rest of it. To position it, in my opinion there's no the exact way to do it, since it all depends on your HTML markup and the way you position it. So, try hacking around until you think that the position similar to the design.
That's it! Hopefully this is helpful!
Marked as helpful