Profile card component challenge

Solution retrospective
I'm finally done with my first challenge. It took me actually 2 weeks for finishing it with phases on and off. I would be glad if somebody can point out some mistakes of mine :)
Please log in to post a comment
Log in with GitHubCommunity feedback
- @ToHX
Hi, thanks for you feedback!
I'm actually a bit confused, as I did learn that I shouldn't use
width
with this card, because this will give it a fixed width which will introduce problems for the responsibility.Also, for font you should never use px, always use rem. This won't make your side inclusive.
- @RioCantre
Hello there! Good job with this project. You out time to finish this one and looking at your solution you did well. I would suggest these for you...
- Inside the
.card
rule set, remove thepadding-left: 1rem;
andpadding-right: 1rem;
. Addwidth: 330px;
- Add
font-size: 11px;
in the rule set of.card-bottom-grid span
- Add
padding: 0 1rem;
in the rule set of.card-bottom-grid p
Hope this helps and Keep going!
- Inside the
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord