Skip to content
Submitted about 4 years ago

Profile Card React Component

Aaron Stroud•435
@astroud
A solution to the Profile card component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I am revising my earlier html/css challenges using React and Styled Components.

Even if you're not familiar with React, you can make sense of the CSS here because Styled Components uses regular CSS code.

I am interested in any and all feedback. Specifically:

  • How's my component code look? (JSX, PropTypes, naming, etc)
  • Do I need to improve my CSS rules? I've used REM everywhere except the media query and when vw worked better.
  • What's your impression of my readme? Too long? Not detailed enough? I'd like it to be useful for FEM members thinking about moving from html/css to React.

Thanks in advance! Aaron

Code

Please log in to post a comment

Log in with GitHub

Community feedback

  • Raymart Pamplona•16,040
    @pikapikamart

    Your's look awesome and btw, you dont need to specify the min-width if you're using clamp. The first argument is the minimum size of what you are clamp-ing with^ Also just a question, is yarn like gulp? Havent use yarn but im using gulp, is yarn like a preprocessor?

  • ApplePieGiraffe•30,525
    @ApplePieGiraffe

    Hey, Aaron Stroud! 👋

    Good to see you complete another challenge! 😀

    I'm no React expert but your code seems pretty good, I think (you're putting props and prop types to good use, so that's nice). 👍

    I think your README is fine, as well, and contains a nice little introduction to styled-components. 🙂

    Overall, nice work! 👏

    Keep coding (and happy coding, too)! 😁

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord