Submitted 3 months ago

Profile Card React Component

Solution by

This is a solution for...

Design Comparison

SolutionDesign

I am revising my earlier html/css challenges using React and Styled Components.

Even if you're not familiar with React, you can make sense of the CSS here because Styled Components uses regular CSS code.

I am interested in any and all feedback. Specifically:

How's my component code look? (JSX, PropTypes, naming, etc)
Do I need to improve my CSS rules? I've used REM everywhere except the media query and when vw worked better.
What's your impression of my readme? Too long? Not detailed enough? I'd like it to be useful for FEM members thinking about moving from html/css to React.

Thanks in advance! Aaron

P
ApplePieGiraffe24,205 | Posted 3 months ago
Hey, Aaron Stroud! 👋
Good to see you complete another challenge! 😀
I'm no React expert but your code seems pretty good, I think (you're putting props and prop types to good use, so that's nice). 👍
I think your README is fine, as well, and contains a nice little introduction to styled-components. 🙂
Overall, nice work! 👏
Keep coding (and happy coding, too)! 😁
1
Raymart Pamplona4,410 | Posted 3 months ago
Your's look awesome and btw, you dont need to specify the min-width if you're using clamp. The first argument is the minimum size of what you are clamp-ing with^ Also just a question, is yarn like gulp? Havent use yarn but im using gulp, is yarn like a preprocessor?
1

Give some feedback to astroud about their solution...