@ApplePieGiraffe
Posted
Hey, Aaron Stroud! 👋
Good to see you complete another challenge! 😀
I'm no React expert but your code seems pretty good, I think (you're putting props and prop types to good use, so that's nice). 👍
I think your README is fine, as well, and contains a nice little introduction to styled-components. 🙂
Overall, nice work! 👏
Keep coding (and happy coding, too)! 😁
1
@ApplePieGiraffe
Posted
@ApplePieGiraffe
Oh yeah, and I forgot to mention, you might want to check the position of the background images in the mobile layout since they don't change their position since the desktop layout and don't seem to be visible on smaller screens. 😉
1
@astroud
Posted
@ApplePieGiraffe
Thanks for pointing out the background on mobile screens. It's fixed now. This is actually a refactor of an older challenge. I'm going to refactor my older straight html/css submissions using React.
I really am loving Styled Components. To me (with my limited experience), they feel like the best way of integrating CSS.
1
@ApplePieGiraffe
Posted
@astroud
Okay, sounds good! 👍
Yeah, I just learned about styled-components, too, and I think they're pretty awesome! 😀
1
@astroud
Posted
Hey @ApplePieGiraffe , please reply to this comment. I'm trying to help Matthew track down a bug where the email notification for a new comment sometimes results in a broken link like this: https://www.frontendmentor.io/solutions/undefined#feedback
1
@ApplePieGiraffe
Posted
@astroud
Oh, yeah, I've come across that bug on several occasions. I'm not certain, but I think it (or a similar bug) might occur when someone submits a new comment and an email notification is sent and they delete (or perhaps edit) their comment soon afterward. That's just a guess, though. 🧐
0