Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Profile Card Component

Mohammed Abedβ€’ 210

@abedmohammed

Desktop design screenshot for the Profile card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Any feedback is appreciated

Community feedback

Adrianoβ€’ 34,000

@AdrianoEscarabote

Posted

Hello Mohammed Abed!

You did a good job on this challenge. your project has some html issues:

1- Document should have one main landmark, you could have pasted all the main content inside a main tag to make the code more semantic [click here to know more about](https://dequeuniversity.com/rules/axe/4.3 /landmark-one-main?application=axeAPI)

2- Page should contain a level-one heading click here to read about it

3- you can use a media query to activate a padding so that the content doesn't hit the edge

  .container {
    padding: 1rem;
  }
}```

But the rest was really good.
**Congratulations  πŸ₯³ **

Marked as helpful

1

Mohammed Abedβ€’ 210

@abedmohammed

Posted

@AdrianoEscarabote Thank you very much! this is really helpful and detailed

0
Lucas πŸ‘Ύβ€’ 104,560

@correlucas

Posted

πŸ‘ΎHello Mohammed, congratulations for your solution!

Instead of using position: relative to align the profile photo you can use margin-top: -50px; to change its alignment and put it between the two layers, using position relative you'll have less control over the profile when the container starts to scale down.

There's also a issue that the image isn't scaling with the container, this is due some fixed width/ height.

Congrats!

Marked as helpful

0

Mohammed Abedβ€’ 210

@abedmohammed

Posted

@correlucas Thank you very much for the feedback!

This makes a lot more sense to what I was doing

1
Mohammed Abedβ€’ 210

@abedmohammed

Posted

@correlucas Using top: -50px worked very for me but I have an issue i cannot figure out. How do I make the profile picture responsive? Usually when I use max-width on an image (in my reset css folder at root), it is able to resize when the entire container starts becoming smaller. However this is not happening here.

Is this because of the margins?

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord