Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 4 years ago

Profile Card Preview - HTML and CSS

Dan•10
@unknowncodester
A solution to the Profile card component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


I didnt opt to use sass as I have used it in the past and wanted to just concentrate on css and html. Any tips such as those below would be much appreciated;

  • positioning the background images
  • designing the page to be have more responsiveness
  • making the html more semantic (html5)
  • whether i should have not used absolute position for the profile image and whether i should be mixing absolute with a css grid
  • accessbility
  • and general css/html tips
Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Jane•1,040
    @janegca
    Posted over 4 years ago

    Hi Dan, your page looks very close to the design and is responsive except for those pesky background images which tend to trip up a lot of people (me included). Check out Afolabi's Solution for a simple way to handle them.

    On the HTML side, you don't need the 'section' tags in the footer section, all the text is already in paragraph blocks and you are only directly targeting the spans so I think they can be safely removed. Also, the W3C rules say the section tag should be used only if the content they wrap would be included in a table of contents (hence the need for a header tag h2-h6). If you really need a wrapper to style something correctly a div is fine.

    Your use of absolute to position the avatar image isn't necessarily wrong or right; it works. There are other ways, transform: translate() can work too.

    Hope that's of some help. Happy coding.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub