Profile-Card-Component
Solution retrospective
Please feel free to give me feedback,it will be a lot of help,correct me or give me advice anything is welcome
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@danielmrz-dev
Hello @shivani1410551!
Your solution looks great!
I have a suggestion for improvement:
- Use
<main>to wrap the main content instead of<div>. The tag<main>is meant for the main content of the page, not the card's main information. Since the card is all we have on the screen, the whole thing is the main content.
📌 Tags like
<div>and<span>are typical examples of non-semantic HTML elements. They serve only as content holders but give no indication as to what type of content they contain or what role that content plays on the page.This tag change does not impact your project visually and makes your HTML code more semantic, improving SEO optimization as well as the accessibility of your project.
I hope it helps!
Other than that, great job!
Marked as helpful - Use
- @gfunk77
Hi! Congratulations on your solutions. It looks really nice. I’ll offer a few general suggestions:
- on the body use min-height: 100vh
- avoid using fixed widths and heights on elements. This hinders responsiveness.
- use max-width if you want to specify a limit to how much an element would grow.
- remove unused classes from your html. You have several classes like likes, followers in your html that you do not select in the css
- try as much as possible to select classes directly. For example, limit things like this:
.main .profile-img-wrapper img. Just put a class on the img and select that. It is much more readable.
I hope this is all helpful.
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord