Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

Project tracking intro component master

Luis 930

@luis08201

Desktop design screenshot for the Project tracking intro component coding challenge

This is a solution for...

  • HTML
  • CSS
  • JS
2junior
View challenge

Design comparison


SolutionDesign

Solution retrospective


Hello everyone.

This is my second attempt at this challenge, but I have added the fade event and coded mobile-first.

I'm not used to building websites that way, but I've found that it's easier than starting to build from width: 1440px.

I would love to hear any comment, it'd help me a lot to improve my skills in building websites.

Happy Coding :D.

Community feedback

@pikapikamart

Posted

Hey, awesome work on this one. Desktop layout looks great, it is responsive and mobile state looks great as well.

Some suggestions would be:

  • You shouldn't have used header to wrap the whole layout. Instead on this one, you should have:
<header />
<main />

header only contains the topmost part, the navbar and the rest should be inside the main as they are the main-content of the page.

  • Since you are treating the website-logo a link, include it inside the nav since it is navigational link.
  • Website-logo-link a tag should have either aria-label attribute or sr-only text inside, that describes where the link would take the user. Usually, website-logo directs user to homepage so use homepage as the value like `aria-label="homepage".
  • Remember that a website-logo is one of the meaningful images on a site so use proper alt for it. Use the website's name as the value like alt="sneakers".
  • Remember that a website-logo is one of the meaningful images on a site so use proper alt for it. For this, since it is hard to tell the name, you could use project tracking as the name for the img.
  • Include the login inside the ul.
  • You don't need to use figure on the image because, figure is used combine with its figcaption tag.
  • Add an extra aria-hidden="true" on the hero-section image. Decorative images should be hidden for screen-reader at all times by using alt="" and aria-hidden="true" to the img tag or only aria-hidden="true" if the image is using svg.
  • I think monograph dashboard could be the h1 on this? Since if you think about it, it is more descriptive than POWERFUL INSIGHTS INTO YOUR TEAM right, to describe the section.
  • The to see a preview is not really a interactive component, that would be just a plain text so use p tag on it.

MOBILE

  • hamburger menu should be using a button since it is an interactive component.

SUPPOSING BUTTON IS USED

  • The button should have a default atribute of aria-expanded="false" and it will be set to true when the users toggles it and vice-versa.
  • The hamburger button should have either aria-label attribute or sr-only text inside it which defines what the button does. You could use aria-label="navigation dropdown menu"

Aside from those, great job again on this one.

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord