@pikapikamart
Posted
Hey, awesome work on this one. Desktop layout looks great, it is responsive and mobile state looks great as well.
Some suggestions would be:
- You shouldn't have used
header
to wrap the whole layout. Instead on this one, you should have:
<header />
<main />
header
only contains the topmost part, the navbar and the rest should be inside the main
as they are the main-content of the page.
- Since you are treating the website-logo a link, include it inside the
nav
since it is navigational link. - Website-logo-link
a
tag should have eitheraria-label
attribute orsr-only
text inside, that describes where the link would take the user. Usually, website-logo directs user to homepage so usehomepage
as the value like `aria-label="homepage". - Remember that a website-logo is one of the meaningful images on a site so use proper
alt
for it. Use the website's name as the value likealt="sneakers"
. - Remember that a website-logo is one of the meaningful images on a site so use proper
alt
for it. For this, since it is hard to tell the name, you could useproject tracking
as the name for theimg
. - Include the
login
inside theul
. - You don't need to use
figure
on the image because,figure
is used combine with itsfigcaption
tag. - Add an extra
aria-hidden="true"
on the hero-section image. Decorative images should be hidden for screen-reader at all times by usingalt=""
andaria-hidden="true"
to theimg
tag or onlyaria-hidden="true"
if the image is usingsvg
. - I think monograph dashboard could be the
h1
on this? Since if you think about it, it is more descriptive thanPOWERFUL INSIGHTS INTO YOUR TEAM
right, to describe the section. - The
to see a preview
is not really a interactive component, that would be just a plain text so usep
tag on it.
MOBILE
- hamburger menu should be using a
button
since it is an interactive component.
SUPPOSING BUTTON IS USED
- The
button
should have a default atribute ofaria-expanded="false"
and it will be set totrue
when the users toggles it and vice-versa. - The hamburger
button
should have eitheraria-label
attribute orsr-only
text inside it which defines what thebutton
does. You could usearia-label="navigation dropdown menu"
Aside from those, great job again on this one.