@pikapikamart
Posted
Hey, another really nice solution from yours. The desktop layout looks really great, site is responsive and the mobile state looks really great.
Extra props for manually adding those animations for each of the rect
. It suits really well on this layout.
Others already gave their feedback on this one, just going to add some suggestions:
- On the
header
, the hamburger-button should be the one using thedisplay: none
and not theimg
inside it because it will still allow thebutton
to be traversed. Even though at desktop, you cantab
on it. - Inside the
main
tag, your markup should be making theh1
as the first text content of themain
. Right now, the first text-content is thenew
word. So when navigating using landmark, my screen-reader will announcenew
instead of theh1
. You should swap theh1
with thediv
wrapper of the 2p
tag. Then you could just usegrid
on the.main__content
so that you could place each item properly like on the design.
Just those only. Again, this is really nice and great job again on this one.
Marked as helpful
Hey @pikapikamart thanks for the nice words and suggestions 👌🏻
@brodiewebdt
Posted
@martpika I'm saving all these tips you've been giving out in a text file for future reference. Thanks.