Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 1 year ago

proyecto QR

jhonjunior1•10
@jhonjunior1
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


CRITICAS CONTRUCTIVAS

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Mcnafaha•240
    @TheMcnafaha
    Posted over 1 year ago

    Hola @jhonjunior1!

    Despues de ver tu applicacion es claro que tienes un buen futuro en esta industria.

    Tengo una critica contructivas para ti:

    Ten cudido con las tags titulares de HTML. Por ejemplo, esta parte de tu HMTL es un poco confusa.

    <h1>Improve your front-end skills by building projetcts</h1>
    <h2>Scan the QR code to visit Frontend Mentor and take your coding skills to the next level</h2>
    <h3>Realizado Por</h3>
    <h4>Jhon Suarez</h4>
    

    Las tags titulares de HTML se usan para crear titulos o crear la jerarquía de un documento.

    Este es un ejemplo de un articulo en MDN usando las tags titulares de HTML:

    h1 Harry Potter
        h2 Sypnosis
        h2 Novelas
            h3 Harry Potter y la Piedra Filosofal
            h3 Harry Potter y la Cámara de los Secretos
            h3 Harry Potter y el Prisionero de Azkaban
            h3 Harry Potter y el Cáliz de Fuego
            h3 Harry Potter y la Orden del Fenix
            h3 Harry Potter y el Príncipe Mestizo
            h3 Harry Potter y las Reliquias de la Muerte
    

    Como puedes ver, las tags crean una divison de niveles que aqui se demustra usando espacios. Usando esa misma idea, asi se ve tu applicacion:

    h1 Improve your front-end skills by building projetcts
            h2 Scan the QR code to visit Frontend Mentor and take your coding skills to the next level
                h3 Realizado Por
                    h4 Jhon Suarez
    

    Creo que una mejor forma seria usando la tag <p> y talves una <h1>. Algo como asi:

    h1 Improve your front-end skills by building projetcts
     p Scan the QR code to visit Frontend Mentor and take your coding skills to the next level
     p Realizado por Jhon Suarez
    
    Marked as helpful
  • jhonjunior1•10
    @jhonjunior1
    Posted over 1 year ago

    Si si gracias por tu criticas, hay falle fui yo lo tendre en cuenta , gracias por comentar.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub