Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted almost 5 years ago

Pure CSS

crooz•95
@bobbycrooz
A solution to the Article preview component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


It's a beginner level code, where do i need to improve on?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • P
    Carlos Loureda•150
    @carlosloureda
    Posted almost 5 years ago

    Hi Crooz! Great start with CSS skills.

    I am also new at this site. I was checking your solution and if you see the report that is generated by the site you have 4 accesability issues and 2 HTML issues, check the report here

    If you want to check your HTML/CSS validation you can use these online resources:

    • HTML validator
    • CSS validator

    Tips about folder arquitecture

    For these projects it might not be needed but it can be a good training to begin to add .js files into a js folder and .css files into a css or styles folder, you can check a nice medium post about this

    Icons Nice addition of _fontawesome` icons, I use them a lot, but for this exercise if I recall it well they asked to use only the assets provided, so in this project you have 3 svg icons provided on the images folder. The result is very nice but for the sake of the exercise I would try to use them, remembe: r that in this industry we will be needing to follow orders from product owners or designers.

    Css

    Checking out your code everything looks great, good work! I only see you used some ids for styling: #share-icon, #share-icon2. It is recommened to use classes over ids

    Design

    • I see a little line break between the side image and the content on the right, maybe making the container have the corner borders instead of adding borders to the card2 element would improve that little difference.
    • If you check the original side image you can see that the right margin is cutting the image at the end of the green table, in my solution I moved the image using:

    object-fit and object-position

    Great overall design and cool code! I am also learning CSS hope these tips help you and don´t hesitate to ask anything!

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub