@mattstuddert
Posted
Hey Jakub, it's great to see you posting a solution for this challenge. I hope you enjoyed it! As @hoehooiyan mentioned, your BEM naming is fine and you would definitely benefit from looking into folder architecture for your styles. The 7:1 pattern is great. Others to look into and take inspiration from are SMACSS and ITCSS. If you research those 3 you'll be in a great position to start structuring your projects in a way that will scale well with larger projects.
As for the accessibility of the project, here are a few things that I've picked up:
- You've got accessibility errors in your report, which could be resolved. Bethany has provided a great resource for you to learn more.
- For the
alt
text on the open and close icons for the mobile menu, you're currently being very literal with "menu open icon" and "menu close icon". Try to be more descriptive of the action in these situations. For example, "Open menu" and "Close menu". - Your buttons for the team page are currently missing
alt
text, which will make them inaccessible to screen reader users as it won't describe the action. - You're also missing labels or
aria-label
attributes on the contact page form. These are needed for screen reader users to know what the input is for. The accessibility report hasn't picked these up as it currently only tests the homepage, which is something we'll be changing soon.
One other small point: the "Contact Us" links in the "Ready to get started?" section on the homepage and about page currently don't link to the contact page.
Keep up the great work!