QR Basic HTML & CSS

Community feedback

• 

  Agnik Bakshi•480

  @Agnik7

  Posted over 2 years ago

  Hi, Congratulations on solving this challenge🎉🎉🎉.

  You have an almost perfect solutions, however I have 2 points that might help you.

  • Replace the ending div tag with a footer tag, since the content is supposed to be the footer.

  <footer class="attribution">
      Challenge by <a href="https://www.frontendmentor.io?ref=challenge" target="_blank">Frontend Mentor</a>. 
      Coded by <a href="#">Dan Mahony</a>.
  
      </footer>
  

  • Although the card size and the image position is perfect, the text seems to be slightly off. I think that could be fixed by proving a top bottom margin of around 1rem or 0.5rem to the header tag.

  Hope you find this comment useful. Please feel free to correct me, if I have mentioned any incorrect information.

  Have a nice day!!

  12

  Marked as helpful