romila• 3,570
@romila2003
Posted
Hi Lalit,
Welcome to the frontend mentor community and congratulations for 🎉 for completing your first challenge, the card looks great. I found some issues I want to address:
- It is best practice to wrap the main content within the
main
tag which would ensure that your content is wrapped within the correct landmarks e.g.<main class="container"></main>
- You are missing the
title
tag within yourhead
tag e.g.<title>QR code component</title>
- Your
img
tag is missing thealt
tag. - Rather than using the
margin-top
property to center the card, you can useflex
property instead e.g.
body {
display: flex;
align-items: center;
justify-content: center;
min-height: 100vh;
}
Overall, great attempt and wish you the best for your future projects so keep coding 👍.
0
Lalit Aditya• 10
@lalit-aditya
Posted
@romila2003 Hey Romila, Thank you for your recommendations. I appreciate your code.
1