Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted 5 months ago

Qr Challenge

antonio•70
@Antonio-Manoel-S
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

Never, never link your repo with all the project files on a paste, inside the paste. The github site only read html on the root paste.

What challenges did you encounter, and how did you overcome them?

The god darm Github Site that only read on root paste.

What specific areas of your project would you like help with?

The proportions of the main box, i dont get well what size of the padding and stuff.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Ritwik Pai•50
    @CoiferousYogi
    Posted 5 months ago

    Hello. I just came across your post. First of all, well done for completing a challenge. Every challenge helps to learn something or the other. If you don't mind, let me share some points which will help you to improve. Your basic design of the card is good. But some of the areas can be improved.

    1. The area around the QR Code image. In the design, you can see that it's an uniformly spread area. I achieved this using the padding property. You can do this too by applying a padding of, say, 1rem to the div element containing the QR code image.
    2. Secondly, the same for the text elements below. Add an appropriate padding so that the text does not appear crossing the boundaries of the image.
    3. Please change the colour of the text elements. It's easy to miss that. Please refer to the design template to get the colours and apply them accordingly.
    4. For your query about the sizes and proportions of the elements, it's really about practice. Most of the times, you will have to experiment a bit to get the correct proportions. The solutions do not have to be a carbon-copy of the design if exact proportions have not been provided. Suppose, for this particular example, the card div is approximately a rectangle with a ratio between 3:2 and 4:3. I did this by experimenting on the div. Hope this helps.

    Wish you the very best.

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub