Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted about 1 month ago

QR code - my first frontend mentor challenge.

Victor Elgersma•40
@victorelgersma
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


What are you most proud of, and what would you do differently next time?

I actually followed a tutorial to do this as I got quite stuck trying to get the card styling to work. So I am most proud of the fact I finished it to begin with. That said, I am most proud of the variables calculation I used to make sure that the relationship between the inner and outer radius is fixed, no matter what the padding is (i.e I set it up so that you can only independently vary the inner radius and the padding -the outer radius is always calculated for you).

Quite happy with the organisation, especially that I am defining variables for the colors at the top of the CSS file.

What challenges did you encounter, and how did you overcome them?

Couldn't figure out the right markup for it. Watched a tutorial to finish it.

What specific areas of your project would you like help with?

Am I following best practices by defining variables on the :root CSS element?

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Elmar Chavez•580
    @CodingWithJiro
    Posted about 1 month ago

    Yes you are following best practices using CSS variables. I use this technique as well since changing one thing to apply to several elements is a big help if working on bigger projects.

    One note though, you can capitalize all the letters in your variable name so its easier for other developers when looking at your code.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub