QR Code

Hi there, good job. Here is my feedback:

HTML:

• Every webpage needs a <main> that wraps all of the content, except for <header> and footer>. This is vital for accessibility, as it helps screen readers identify a page's "main" section. Change .container to a <main>.

• The image has meaning, so it must have proper alt text. Write something short and descriptive, without including words like "image" or "photo". Screen readers start announcing images with "image", so an alt text of "image of qr code" would be read like this: "image, image of qr code". The alt text must also say where it leads(frontendmentor website).

CSS:

• Including a CSS Reset at the top is good practice.

• Add around 1rem of padding on the body, so the card doesn't touch the edges on small screens.

• On body, remove font-optical-sizing, font-weight and font-style, as your values are already the default values. Add justify-content: center to center the card horizontally.

• Remove the margin on .container, and move max-width to .card. It must be in rem - around 20rem works well.

• font-size must never be in px. This is a big accessibility issue, as it prevents the font size from scaling with the user's default setting in the browser. Use rem instead.

• On the image, add display: block and change width to max-width: 100% - the max-width prevents it from overflowing its container.