qr code

Community feedback

• 

  adityaac7•30

  @adityaac7

  Posted about 1 year ago

  Great work finishing with your project! Your implementation is really close to the given design.

  First off, I have just finished the project myself and may not be an expert enough to point out your project's advantages and disadvantages, so please take my review with a grain of salt!

  What I did notice is that you have used plently of semantic HTML tags, and your class names are relevant and precise to the object in picture. You have used a CSS Grid to center your component which to me, seems like the ideal way to do it. Good stuff! Some things I would like to point out that could be coded better are the following:

  1 .body { max-width: 1440px; Some people may have a screen width higher than that. For them, the website might seem bugged. It would be better if you set it such that it covers the whole viewport itself instead of hard-coding the maximum width.

  2 You may need to set adjust the width of your qr-code image to make sure it matches better with the given design.

  3 It is good practice to keep a secondary font (I've usually seen arial) in case your primary does not load. Makes sure your website runs perfectly in any case.

  These are all only small points that I could think of. Overall you did a great job with this project and I hope you continue to build your portfolio with more!

  00

  Marked as helpful