@AdrianoEscarabote
Posted
Hi Marek Brzezinski, how are you? Welcome to the front-end mentor community! I really liked the result of your project, but I have some tips that I think you will enjoy:
Avoid using px
, If your web content font sizes are set to absolute units, such as pixels, the user will not be able to re-size the text or control the font size based on their needs. if you want to keep using px for development and then format the whole code to rem, you can use this vscode extension: px to rem
As this is the main image of the page it cannot have an empty alt
, images must have alt text unless it is a decorative image!
<img class="qrCode" src="images/qr-code.svg" alt="" />
The rest is great!
I hope it helps... 👍
Marked as helpful
@marekbrze
Posted
@AdrianoEscarabote thank you for your comment! It forced me to finally read more about rems and I get it now ;) All of my next project will be better thanks to you ;)
and good catch with alt property!