Skip to content
Submitted almost 2 years ago

QR Code

Zeus Tenerife•80
@zakura1x
A solution to the QR code component challenge
Preview (opens in new tab)Code (opens in new tab)

Solution retrospective

I'm not sure if its fully correct or not

Code

Please log in to post a comment

Log in

Community feedback

  • girldocode•260
    @girldocode

    it looks really nice. just apply border-radius to the image.

    Marked as helpful
  • P
    Øystein Håberg•13,280
    @Islandstone89

    Hi, yes it looks good, but there are a few things you should improve.. :)

    HTML:

    CSS:

    • It's best practice to link to the fonts in the HTML <head> instead of importing it in the CSS.

    • Height on the body should be min-height.

    • Remove all fixed widths and heights. You rarely want to set a fixed size.

    • Remove position: relative and overflow: hidden on the .container

    Marked as helpful

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord