Looking to hire developers?
I found centering difficult but figured it out eventually with help on here. I'm unsure of my accessibility and responsiveness!
@vigengareyan
Posted
Hello,
As a beginner you've done nice job.
If you'd like to solve the accessibility issues, use tags like <main>,<footer> and bring back the div.attribution part of html code, that was there once you downloaded the starter file (don't forget to add the link of your frontend mentor account there).
Also pay attention to the previous comment on your work.
Have a nice coding.
Marked as helpful
@tommysoren
Posted
@vigengareyan Thank you!
@MohamedAridah
Posted
Hello @tommysoren, congratulation on submitting your first solution🎉👏. And Because it's the first solution. you need a lot of improvements to make the solution look similar to the design here are some:
<head> tag in the index.html page. and set body font-family property to be Outfit<head>
<link rel="preconnect" href="https://fonts.googleapis.com" />
<link rel="preconnect" href="https://fonts.gstatic.com" crossorigin />
<link href="https://fonts.googleapis.com/css2?family=Outfit:wght@400;700&display=swap" rel="stylesheet" />
</head>
body {
font-family: 'Outfit', sans-serif;
}
<img>
<h2 class="bold"></h2>
<p class="regular"></p>
you can use
<div class="box-image"></div>
<div class="box-text"></div>
this will give you more control on styling instead of dealing with 3 elements individually you will deal with 2. This will be very useful when dealing with big websites.
* {
padding: 0;
margin: 0;
box-sizing: border-box;
}
I hope this wasn't too long for you, hoping also it was useful😍.
Goodbye and have a nice day.
Keep coding🚀
Marked as helpful
@tommysoren
Posted
@MohamedAridah Thank you very much!
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
