QR Code

Hi there!, congrats on completing this challenge!! 🥳🎊

I have some tips to improve your solution. 💯

HTML:

• Header elements implements six levels h1-h6, with h1 being the most important and h6 being the least important. avoid omitting header levels, your page should start with the header h1 and successively with h2...h6. More info HERE
• Your main content should be conteined in the main tag. More info HERE
• Your img tag, should have alt attribute.

SCSS:

Your reset is good, but you can improve it by using some popular resets like the following 🚀:

• Normalize.css
• Reset.css
• My Custom CSS Reset of Josh Comeau

I can see that your variables are in the partials folder, but your reset is inside your styles.scss file. If you want to organize your files I recommend the following (it's my way of doing it, you can find another way that suits you):

-- scss
---- components
------ _button.scss
------ _nav.scss
---- utilities
------ _variables.scss
---- layout
------ _footer.scss
------ _main.scss
---- base
------ _reset.scss
---- index.scss

Those are some example files, I hope and they are clear. 🙃

I hope I've helped you

Happy coding! ✌️