Looking to hire developers?
What you think? first challenge ever :)
@maqsudtolipov
Posted
Hi there 👋
Congratulate on finishing your project 🎉. You did a great job 🔨
I give some suggestions that I hope help you take your project to the next level 📈.
D5E1EF 😃Happy coding ☕
Maqsud
Marked as helpful
@WEBdevDOR
Posted
@maqsudtolipov Cheers bud! added! will be rendered soon hopefully :)
Hi!
Good job completing your first challenge ever!
The card is a little too big on my phone screen though and extends a bit outside of the viewport when loaded, creating a little bit of horizontal scrolling. Not using fixed values might help with that.
Marked as helpful
@WEBdevDOR
Posted
@perezjprz19 Thanks for your comment! I haven't thought of the responsiveness for the time being, but will be developing furthermore. I've set the entire card width to be 350px as the viewport given for a mobile screen size is 375px. I know it's not the right way of doing it (don't know the actual right way) and any advice on how to actually achieve this would be great!
@Mahmoud2227
Posted
Hey, congratulations on finishing your first challenge. I think that your solution is pretty nice and you can add a first-level heading (h1) to fix the accessibility issue
@WEBdevDOR
Posted
@Mahmoud2227 cheers bud, I'm ahead of you :) just waiting for git.io to update
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord
