Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

qr code attempt

Suki 90

@Suksman03

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Feedbacks are welcome please.

Community feedback

@DennisBoanini

Posted

Hi, try to resolve your HTML errors. First error tell you that the alt attribute is missing on img tag and this is useful when image is not loaded and in this case the alt text is showed. The other error tell you that you placed the style tag in wrong place.

For the card may you can try to increase the sizes

Marked as helpful

2
P

@12Kentos

Posted

Hey @Suksman03,

Nice job on completing the project it looks great!

I looked through your css file and noticed you selected elements directly several times like so.

p { margin-top: 15px; font-size: 15px; font-weight: 700; font-family: 'Outfit',sans-serif; text-align: center; color:hsl(218, 4 4%, 22%); }

While this isn't a problem for small projects like this, it's best to get into a good habit now of selecting pretty much everything with classes, or id's or at least with a little more specificity. That way when you are making changes to a p element, it won't change every single p element on your page. This will help you avoid a LOT of headache on bigger projects.

Keep up the great work!

Marked as helpful

0

Suki 90

@Suksman03

Posted

@12Kentos thank u for the feedback sir. I'll make the corrections.

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord