@natashapl
Posted
Hi Sadas! Welcome to Frontend Mentor. I'm new to this platform as well and recently uploaded the same solution. I took a look at your solutions and it's pretty good. I have a few suggestions.
- Consider wrapping your content in the
main
tag. It helps screen readers and is semantic HTML. You can learn more about the benefits of semantic tags here:
HTML5 Semantic Tags: What They Are and How to Use Them!
- Once you place your content in that
main
tag, you can use it to center you content vertically and horizontally. You can remove theposition: relative
and "top" and "left" from the "background" since you won't need them for positioning . Here's a CSS rule you can try for the main tag:
main { display: flex; align-items: center; justify-content: center; min-height: 100vh; }
- once all your content is centered with the main tag, you can also remove all relative position styles from the content. For example, the
qrcodeimage
can become:
.qrcodeimage { max-width: 100%; width: auto; border-radius: 10px; }
The max-width: 100% is to ensure that the image is fluid.
- Consider hanging the
headerone
div to an h1 tag. It is best practice to always have an h1 tag on your web page.
I hope this helps.
@hmadamk
Posted
@natashapl wow! finally someone who knows about the thing called accessibility I thought I was the only one who's left
@jaggycodes
Posted
@natashapl Thank you so much! This is so helpful.
@natashapl
Posted
@jaggycodes You're very welcome! If it was helpful, please consider marking it as helpful. Thanks! 😊