Skip to content
  • Unlock Pro
  • Log in with GitHub
Solution
Submitted over 3 years ago

QR code box

Daniel•30
@danielfrontendjourney
A solution to the QR code component challenge
View live sitePreview (opens in new tab)View codeCode (opens in new tab)

Solution retrospective


This is what I am able to build with the level I am at.

It would be helpful to get some points on what I need to study more. What it seems I did right and should keep doing.

Code
Select a file

Please log in to post a comment

Log in with GitHub

Community feedback

  • Aziz Najjar•260
    @Njoura7
    Posted over 3 years ago

    hello friend, good job for this project, and congrats for your first project on github here are two tips that might improve your project give the body a display flex like this body{ display:flex; justify-content:center; /to center the container horizontally in your case/ alignm-items:center; /to center the container vertically in your case/ } another method to do it without flexblox is to center your container directly: .container{ position:absolute; top:50%; left:50%; transform:translate(-50%,-50%); }

    the other tip is to give your QR code img a width of 90% or 85% instead of max-width:100%; or you can give your container a padding of 1rem maybe hope it was helpful :D

  • Angel Reynoso•30
    @Angelr2909
    Posted over 3 years ago

    Buen trabajo bro, asi se comienza, puedes usar en el body un vh de 100vh para asi utilizar el 100% de la pantalla y centrar el div container con justify-content y aling items ambos en center, recuerda establecer la propiedad flex para poder hacer uso de jc y ai. Luego tambien podrias agregarle un padding al container de unos 20px o bien aplicar un margin a la imagen para que no quede pegado al div contenedor.

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord
Frontend Mentor logo

Stay up to datewith new challenges, featured solutions, selected articles, and our latest news

Frontend Mentor

  • Unlock Pro
  • Contact us
  • FAQs
  • Become a partner

Explore

  • Learning paths
  • Challenges
  • Solutions
  • Articles

Community

  • Discord
  • Guidelines

For companies

  • Hire developers
  • Train developers
© Frontend Mentor 2019 - 2025
  • Terms
  • Cookie Policy
  • Privacy Policy
  • License

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

How does the accessibility report work?

When a solution is submitted, we use axe-core to run an automated audit of your code.

This picks out common accessibility issues like not using semantic HTML and not having proper heading hierarchies, among others.

This automated audit is fairly surface level, so we encourage to you review the project and code in more detail with accessibility best practices in mind.

How does the CSS report work?

When a solution is submitted, we use stylelint to run an automated check on the CSS code.

We've added some of our own linting rules based on recommended best practices. These rules are prefixed with frontend-mentor/ which you'll see at the top of each issue in the report.

The report will audit all CSS, SCSS and Less files in your repository.

How does the HTML validation report work?

When a solution is submitted, we use html-validate to run an automated check on the HTML code.

The report picks out common HTML issues such as not using headings within section elements and incorrect nesting of elements, among others.

Note that the report can pick up “invalid” attributes, which some frameworks automatically add to the HTML. These attributes are crucial for how the frameworks function, although they’re technically not valid HTML. As such, some projects can show up with many HTML validation errors, which are benign and are a necessary part of the framework.

How does the JavaScript validation report work?

When a solution is submitted, we use eslint to run an automated check on the JavaScript code.

The report picks out common JavaScript issues such as not using semicolons and using var instead of let or const, among others.

The report will audit all JS and JSX files in your repository. We currently do not support Typescript or other frontend frameworks.

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub

Oops! 😬

You need to be logged in before you can do that.

Log in with GitHub