QR code card

Community feedback

• 

  Vanza Setia•27,715

  @vanzasetia

  Posted almost 3 years ago

  Hi there! 👋

  Congratulations on finishing this challenge! 👏

  Some recommendations from me.

  • I would not recommend wrapping the img element with picture element if only one image is used for all screen sizes. You want to use picture element for the following reasons (source: MDN documentation).
    • Art direction. Cropping or modifying images for different media conditions (for example, loading a simpler version of an image which has too many details, on smaller displays).
    • Offering alternative image formats, for cases where certain formats are not supported.
  • You can make this website fully responsive without any media queries. The styling for the card is consistent on all screen sizes. Also, I suggest using max-width to limit the width of the card. This way, the card is allowed to shrink if ever needed which means it is way more responsive.
  • I recommend simplifying the HTML markup by not using any div elements.

  Hope this helps. 🙂

  00