Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code card component

#react#material-ui
Mimchi 10

@Ali-Chimim

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Is it a good practice to use inline-style?

Community feedback

@debjit

Posted

@Ali-Chimim Excellent work. I like your solution, but if you're using react, using inline-style makes more sense when using developement. However, please move inside a class if you are developing for a client.

It appears that you built this using React. For your upcoming project, I'll suggest using tailwindcss.

Marked as helpful

1

@alfredthompsonOvie

Posted

By inline styles, do you mean using the style attribute on HTML elements?? It's bad practice, because (1) you're not considering separation of concern, and (2) it increases the specificity of that element thereby making it more difficult to change the styles from your CSS style sheet

1

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord