Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR Code Card Component in React

#react
P
visualdennis 8,255

@visualdenniss

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Here is my attempt at QR Code Card using React and plain vanilla CSS. I gave the QR img a fixed width of 285px, as it looks like from the design its enough for both mobile and desktop devices without any media query or so. All feedback is welcome ofc :)

Community feedback

Hiro 40

@hiro5900

Posted

This looks really good and identical.👍

0

@frank-itachi

Posted

Hello there 👋. Congratulation for completing the challenge👍!

I have some suggestions about your code that might interest you.

HTML 📄:

  • Wrap the page's whole main content in the <main> tag.
  • If your code has different sections that have a specific purpose like a navigation, article, sections or footer, it’s a good practice to enclose those parts with HTML5 landmarks. For example, you could use a <footer> tag to wrap the <div class=”attribution”> section.
  • The heading order is important in the html structure so try to always start your headings and/or titles with an <h1> tag and then you can decrease by one if you need to use more heading in your html code.

I hope you find it useful! 😄 Above all, you did a good job!

Happy <coding /> 😎!

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord