Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

QR code card component

@khalilnazari

Desktop design screenshot for the QR code component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


Dear members,

another challenge is resolved. Please share your idea if any improvement is needed.

Cheers!

Community feedback

Mo 840

@MohamedAridah

Posted

Hello @khalilnazari, your solution is very impressive, and your code is clean enough.

  • the only note for you is to use min-height: 100vh for the body instead of using height: 100vh. This will allow your content to take more vertical height if content needed to. So user can see all the content.
  • you can set text-align directly to .card .card__body div instead of h1 and p. because they both share the same value. The current solution is totally fine and right

For Accessibility issues

you can just put .container div inside <main> tag. This should fix your accessibility issues.

I hope this wasn't too long for you, hoping also it was useful😍.

Goodbye and have a nice day.

Keep coding🚀

Marked as helpful

0

@khalilnazari

Posted

Hi @MohamedAridah,

Thanks for the highlight. Sure, I'll update the code.

0
Mo 840

@MohamedAridah

Posted

@khalilnazari

You are welcome🌹👍

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord