@MohamedAridah
Posted
Hello @khalilnazari, your solution is very impressive, and your code is clean enough.
- the only note for you is to use
min-height: 100vh
for thebody
instead of usingheight: 100vh
. This will allow your content to take more vertical height if content needed to. So user can see all the content. - you can set
text-align
directly to.card .card__body
div instead of h1 and p. because they both share the same value. The current solution is totally fine and right
For Accessibility issues
you can just put .container
div inside <main>
tag. This should fix your accessibility issues.
I hope this wasn't too long for you, hoping also it was useful😍.
Goodbye and have a nice day.
Keep coding🚀
Marked as helpful
@khalilnazari
Posted
Hi @MohamedAridah,
Thanks for the highlight. Sure, I'll update the code.
@MohamedAridah
Posted
@khalilnazari
You are welcome🌹👍